Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new player configuration option which turns off match fetching completely for that player. #2

Open
chris-gooley opened this issue Sep 28, 2016 · 3 comments

Comments

@chris-gooley
Copy link
Owner

Players who have show_own set to false do not have their personal matches displayed and are only identified in team matches. However all their matches are still pulled from the Steam API.

This needs to be reworked so they can be identified in other players matches without having to pull their own list from Steam.

@bigomega
Copy link

This can't be optimized much. In the worst case scenario, you can skip ONE player, the one we check last would not be needed if show_own is set to false for him.

@chris-gooley
Copy link
Owner Author

Hmm, this is an issue if you still want to see team matches that include only people with show_own set to false. Which is a pretty probable use case.

I think it could still be optimised by adding another configuration option to players called fetch_matches for those players who you just want to identify when they appear in matches, but don't care about any matches they have which don't include team members. I will amend the issue to reflect this.

Thanks, I appreciate the input.

@chris-gooley chris-gooley changed the title Dont fetch matches for those players who have show_own set to false Implement new player configuration option which turns off match fetching completely for that player. But still displays them in team matches. Oct 24, 2016
@chris-gooley chris-gooley changed the title Implement new player configuration option which turns off match fetching completely for that player. But still displays them in team matches. Implement new player configuration option which turns off match fetching completely for that player. Oct 24, 2016
@bigomega
Copy link

btw, just implemented this in my channel and it looks amazing. Great work man.

Also, I understand your case there, but I think you're complicating it. Think about it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants