Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redux, Redux Actions and Redux Promise should be peer dependencies? #26

Open
sebas5384 opened this issue Aug 24, 2016 · 1 comment
Open

Comments

@sebas5384
Copy link
Contributor

sebas5384 commented Aug 24, 2016

If we look at projects like react-redux, redux-actions or redux-promise we can notice that their are using peerDependencies for the redux-* dependencies.

I think we should follow this pattern because redux it self for example must be a direct dependency of the project which is using or implementing these libs. It's more easy to know what dependencies the project has, but at the same time removes some kind of abstractions which could help legibility.

Should we move redux, redux-actions and redux-promise to peerDependencies?

@sebas5384
Copy link
Contributor Author

sebas5384 commented Feb 15, 2017

Redux Actions now required defaultState in the handleActions function, so we need to considerate to improve this dependency.
redux-utilities/redux-actions#127
redux-utilities/redux-actions#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant