-
-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider white-space : pre-line as a native part of hint--large #223
Comments
@bjbarouch Thank you for your appreciation! If this proposal goes forward, another decision point would be whether to go with |
Using I had some trouble with the resulting layout with hint.css when trying it out on mobile -- it ran off the edge of the screen, so I looked around some more, and I've switched to using tippy. Being javascript-based, it has its own location intelligence and also offers embedded HTML and many other features. What you are doing in a css-only approach is awesome, but for my style of working, the greater functionality that comes from using js is a better fit. I'd still encourage you to do this pre-line thing because it's easy, useful, and backward-compatible. Surely some hint.css users will consider it a nice to have. |
Thanks for your beautifully structured and commented scss.
On those rare occasions when I put more text in a hint than most people would consider doing, I want to be able to use newlines within the hint. Unsurprisingly, this always coincides with using hint--large. As such, after I load hint.css, I drop this in:
.hint--large:after {
white-space : pre-line;
}
In other hint--sizes, pre-line doesn't play well, but as best I can tell, in hint--large it has no impact on normal amounts of text (it's backward-compatible), and is helpful for the rare, long hint that benefits from being broken up by newlines. As a practical example, consider a frequently useful hint for password fields such as:
At least one each of upper case, lower case, numeral, and other character.
At least 12 characters long.
It's not very long, but it's a bit bulky without the injected newline, and I think easier to read with the newline.
The text was updated successfully, but these errors were encountered: