-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portable health checks #947
Comments
adfoster-r7
changed the title
Add support for relative builds only
Add support for relative builds only / configurable health checks
Jun 5, 2020
adfoster-r7
changed the title
Add support for relative builds only / configurable health checks
Portable health checks
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The current implementation of the omnibus health check requires that either linked files match the project's root dir.
For our project we wish to produce builds that work relatively by making use
@executable_path
, which unfortunately fails the current implementation of the omnibus health check.Detail
For instance, as an example of a happy path lib, there is a reference directly to
/opt/metasploit-framework
- the project install dir:Unfortunately the current check does not correctly handle the scenario of
@executable_path
being present in linked files:In this scenario the healthcheck fails:
As we're wanting to use Omnibus to produce builds that can work from any location. It would be great to configure the Omnibus installer to consider any absolute paths to the project's install dir to now considered a failing health check.
Example code
This implementation wouldn't be suitable for landing to
chef/omnibus
- but it's a good starting point for discussion:rapid7#1
Omnibus Version
7.0.12
Platform Version
OSX
Build Output
Without being able to configure the health check to support whitelisting links:
Example requirement: rapid7#1
The text was updated successfully, but these errors were encountered: