Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow magic numbers when all you are doing is defining a constant. #149

Open
bobwieler opened this issue Jul 8, 2024 · 0 comments
Open
Assignees

Comments

@bobwieler
Copy link
Collaborator

It seems odd that I get an error if I do something like:

const LATEST_ALLOWED_VALIDITY = 90 * 24 * 60 * 60 * 1000; // 90 days in the future in milliseconds

The error is on 90 being a magic number but I'm really just defining a constant and I shouldn't need a separate constant just for the number 90.

@jpolavar jpolavar removed the PICK ME label Jul 16, 2024
@jpolavar jpolavar self-assigned this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants