Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When refetching data as part of HMR, check server availability #362

Closed
rglover opened this issue Nov 3, 2023 · 1 comment
Closed

When refetching data as part of HMR, check server availability #362

rglover opened this issue Nov 3, 2023 · 1 comment
Assignees
@rglover
Labels
feature Something new to add @joystick.js/node Related to the @joystick.js/node package. @joystick.js/ui Related to the @joystick.js/ui package. refactor Something to improve

Comments

@rglover
Copy link
Contributor

rglover commented Nov 3, 2023

If it's unavailable, set a timeout/delay of a few seconds and retry. This should avoid a browser break/reload.
@rglover rglover added feature Something new to add refactor Something to improve @joystick.js/ui Related to the @joystick.js/ui package. @joystick.js/node Related to the @joystick.js/node package. labels Nov 3, 2023
@rglover rglover self-assigned this Nov 3, 2023
@rglover
Copy link
Contributor Author

rglover commented Jul 24, 2024

This is more or less mitigated with the changes in the RC1 release. I let the browser control the timing of the server restart now by pinging the dev server after an HMR update completes in the browser.

@rglover rglover closed this as completed Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rglover rglover

Labels
feature Something new to add @joystick.js/node Related to the @joystick.js/node package. @joystick.js/ui Related to the @joystick.js/ui package. refactor Something to improve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rglover