From 1df87dbe1cc3ad5c732966beaa2087681347f4dc Mon Sep 17 00:00:00 2001 From: JohnAlbin Date: Thu, 5 Oct 2023 20:04:35 +0800 Subject: [PATCH 1/4] fix: update husky dependency --- yarn.lock | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/yarn.lock b/yarn.lock index 6e4a575f..311f9b00 100644 --- a/yarn.lock +++ b/yarn.lock @@ -7545,9 +7545,9 @@ humanize-ms@^1.2.1: ms "^2.0.0" husky@^8.0.2: - version "8.0.2" - resolved "https://registry.yarnpkg.com/husky/-/husky-8.0.2.tgz#5816a60db02650f1f22c8b69b928fd6bcd77a236" - integrity sha512-Tkv80jtvbnkK3mYWxPZePGFpQ/tT3HNSs/sasF9P2YfkMezDl3ON37YN6jUUI4eTg5LcyVynlb6r4eyvOmspvg== + version "8.0.3" + resolved "https://registry.yarnpkg.com/husky/-/husky-8.0.3.tgz#4936d7212e46d1dea28fef29bb3a108872cd9184" + integrity sha512-+dQSyqPh4x1hlO1swXBiNb2HzTDN1I2IGLQx1GrBuiqFJfoMrnZWwVmatvSiO+Iz8fBUnf+lekwNo4c2LlXItg== i18next-fs-backend@^2.1.1: version "2.1.1" From b2acf8b1e0176503ba85f2fddb29130634bae9bc Mon Sep 17 00:00:00 2001 From: JohnAlbin Date: Thu, 5 Oct 2023 20:06:45 +0800 Subject: [PATCH 2/4] fix: update commit-msg hook --- .husky/commit-msg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.husky/commit-msg b/.husky/commit-msg index 4974c35b..c160a771 100755 --- a/.husky/commit-msg +++ b/.husky/commit-msg @@ -1,4 +1,4 @@ #!/usr/bin/env sh . "$(dirname -- "$0")/_/husky.sh" -npx commitlint --edit $1 +npx --no -- commitlint --edit ${1} From aea2cc317edad5d319172274d121c69cfce918fc Mon Sep 17 00:00:00 2001 From: JohnAlbin Date: Thu, 5 Oct 2023 20:11:22 +0800 Subject: [PATCH 3/4] fix: fix commitlint integration Fixes #536 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 47bc64ba..308d21fb 100644 --- a/package.json +++ b/package.json @@ -14,7 +14,7 @@ "test": "jest", "dev": "turbo run dev --parallel", "dev:starter": "lerna run --parallel --scope drupal --scope basic-starter dev", - "prepare": "lerna run prepare", + "prepare": "lerna run prepare && husky install", "watch": "lerna run watch", "lint": "eslint --cache --ext .js,.jsx,.ts,.tsx .", "phpcs": "./drupal/vendor/bin/phpcs -s -n --colors --standard=modules/next/phpcs.xml.dist modules/next", From 91c03fd00d0a6c60456293b4df316095b62e5af8 Mon Sep 17 00:00:00 2001 From: JohnAlbin Date: Thu, 5 Oct 2023 22:43:29 +0800 Subject: [PATCH 4/4] docs: add help text for semantic commit messages --- .commitlintrc.json | 3 +- CONTRIBUTING.md | 103 ++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 104 insertions(+), 2 deletions(-) diff --git a/.commitlintrc.json b/.commitlintrc.json index c30e5a97..3d8d64aa 100644 --- a/.commitlintrc.json +++ b/.commitlintrc.json @@ -1,3 +1,4 @@ { - "extends": ["@commitlint/config-conventional"] + "extends": ["@commitlint/config-conventional"], + "helpUrl": "https://github.com/chapter-three/next-drupal/blob/main/CONTRIBUTING.md#commits" } diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 20d96f24..d413922e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,6 +1,6 @@ # Contributing -Thanks for your interest in contributing to Next.js for Drupal. We're happy to have you here. +Thanks for your interest in contributing to Next.js for Drupal. We're happy to have you here. Please take a moment to review this document before submitting your first pull request. @@ -90,3 +90,104 @@ yarn phpcs Please ensure that the tests are passing when submitting a pull request. If you're adding new features, please include tests. +## Commits + +This project uses git commit messages that follow the [Conventional Commits format](https://www.conventionalcommits.org/en/v1.0.0/). A minor change to your commit message style can: + +- make you a better programmer +- helps to automate the CHANGELOG generated for other developers + +Don’t worry. You can still submit a Pull Request and if you don’t properly use semantic commit messages, we will edit the commits to add them. But we like them, so you might too. + +### Format of the commit message: + +``` +(): + + + +