Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP notices that are raised in unit test suite. #9

Open
m4olivei opened this issue Jan 16, 2017 · 1 comment
Open

Fix PHP notices that are raised in unit test suite. #9

m4olivei opened this issue Jan 16, 2017 · 1 comment

Comments

@m4olivei
Copy link
Contributor

Tests pass, but there are a number of PHP notices that are raised, eg.

https://travis-ci.org/chapter-three/AppleNewsAPI/jobs/192384948

These should be cleaned up.
@m4olivei
Copy link
Contributor Author

I tried for an hour or so to come up with something that would work to test and assert PHP notices and errors, but wasn't able to. Seems like something about how the json() methods do their work, doesn't allow PHPUnit to bubble up an exception correctly to be caught by the test case. 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@m4olivei