Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong backgroundColor validation #21

Open
SergiuSavva opened this issue Aug 30, 2017 · 1 comment
Open

Wrong backgroundColor validation #21

SergiuSavva opened this issue Aug 30, 2017 · 1 comment

Comments

@SergiuSavva
Copy link

SergiuSavva commented Aug 30, 2017

backgroundColor - The article's background color, defined as a 3- to 8-character RGBA hexadecimal string; e.g., #000 for black or #FF00007F for red with an alpha (opacity) of 50%. Defaults to white

src/Document/Styles/DocumentStyle.php

if should be
https://github.com/chapter-three/AppleNewsAPI/blob/master/src/Document/Styles/DocumentStyle.php#L67

  protected function validateBackgroundColor($value) {
    if (!$this->isHexColor($value)) {
      $this->triggerError('backgroundColor is not valid');
      return FALSE;
    }
    return TRUE;
  }
@SergiuSavva SergiuSavva reopened this Aug 30, 2017
aerni added a commit to aerni/statamic-apple-news that referenced this issue Jun 2, 2021
There is an open issue that has to be fixed first: chapter-three/AppleNewsAPI#21
aerni added a commit to aerni/statamic-apple-news that referenced this issue Jun 7, 2021
There is an unfixed issue which makes this method unusable: chapter-three/AppleNewsAPI#21
@RajeevChoudharyNBC
Copy link

What is the alternate for this issue, as removing the setDocumentStyle makes it impossible to implement DocumentStyle class to add backgroundcolor for the article.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants