-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ignored/private packages on "add a changeset if you're a maintainer" link #44
Comments
5 tasks
2 tasks
JounQin
added a commit
to un-ts/changesets-gitlab
that referenced
this issue
May 11, 2023
JounQin
added a commit
to un-ts/changesets-gitlab
that referenced
this issue
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related Issues:
#39: Same root cause, but different use case.
changesets/changesets#436: same issue in CLI.
Problem:
Hi, I've been really enjoying the DX of "add a changeset if you're a maintainer". But whenever a PR modifies both public and ignored/private packages,
changeset/bot
lists all of them in the yaml header. If we don't remove those ignored/private packages manually, this will throwExample PR: aws-amplify/amplify-ui#628. This repository has private
docs
ande2e
packages that are ignored, but they still show up in the "add a changeset" link.Expected Behavior
Remove ignored and/or private packages from changed packages list. This will especially help external contributors that aren't too familiar with the repo.
The text was updated successfully, but these errors were encountered: