Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legitimate redos test case? #45

Open
DevBrent opened this issue Sep 28, 2023 · 0 comments
Open

Legitimate redos test case? #45

DevBrent opened this issue Sep 28, 2023 · 0 comments

Comments

@DevBrent
Copy link

DevBrent commented Sep 28, 2023

If I am not mistaken, this CVE can only be triggered in one of these fairly absurd cases where you're already under attack with nothing less than arbitrary code execution.

  • Someone is actively using get-func-name to process user-generated functions you've already evaluated and then passed the evaluated function into get-func-name.
  • Supply-chain code that has been maliciously modified to have an attack function definition in it AND your code arbitrarily calls get-func-name on this supply -chain code's function.
  • Supply-chain code that maliciously monkey patches function.prototype.toString or the function's own toString with the attack string.

Are there any legitimate test cases (making this a legitimate vulnerability) for this CVE, or did this just get fixed for the sake of responding to the CVE in a timely manner? This is a significant issue in the NPM ecosystem and I'd like to understand if this purely a problem of the CVE classification system or if there are other elements at work here.

Yes, it could be improved but a CVE at all let alone a HIGH SEVERITY CVE is masking more important work out there in the high severity range with legitimate reproduction steps.

GHSA-4q6p-r6v2-jvc5

I don't see how this is a network / remotely triggerable vulnerability that warrants a high CVE score like this.

@DevBrent DevBrent changed the title Legitimate CVE test case? Legitimate redos test case? Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant