generated from cfpb/open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resolve Errors] [Review Warnings] Counts should be the number of rows affected by errors (or warnings) #538
Labels
enhancement
New feature or request
Comments
shindigira
changed the title
[Errors & Warnings] Counts should be the number of rows affected by errors (or warnings)
[Resolve Errors] [Review Warnings] Counts should be the number of rows affected by errors (or warnings)
May 17, 2024
This should be in the filing-api I believe? Code is providing a count of error/warning codes (E3000, W0123, etc) and not the total record counts under each. |
shindigira
added a commit
that referenced
this issue
May 25, 2024
closes #538 closes #539 closes #542 closes #551 ## More changes (05/21/2024) - content(errors/warnings): error/warnings counts and table rows use commas (e.g. 1,000) - stylefix(table): hidden table borders are now present again on single/register fields - content(errors/warnings): record/records changed to 'found' ## More changes (05/20/2024) - style(success error/warnings alert): reduced margin-bottom to 30px (30px between success alert and Filing Nav Buttons) - style(warnings): verify text limited to 670px, well limited to 770px - style(warnings): multifield warnings now also has table borders - feat(errors & warnings): Updated the count to be the rows affected by errors/warnings - ~~content(errors/warnings): added 'record' or 'records' word to count statement~~ ## Changes - style(single/multi/register errors): 45px margin-bottom - style(tables): only multifield errors tables have borders, - content(errors): removed bottom alerts - style(errors/warnings - success): use negative margin (ensures 30px from alert to filing nav buttons) - content(errors): "there is" instead of "there may be" - style(warnings): restrict header to 670px - enhancement(warnings): Reworked warnings alert logic ## How to test (dev) The only functionality changes are in: - enhancement(warnings): Reworked warnings alert logic -- see `FilingWarningsAlerts.tsx` - feat(errors & warnings): Updated the count to be the rows affected by errors/warnings -- see `getRecordsAffected` function. ## Note - Once deployed, @natalia-fitzgerald can verify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the count shows the amount of error (or warning) types found. It should be the number of rows affected by errors (or warnings)
The text was updated successfully, but these errors were encountered: