New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] Remove bottom green border from DS Header on all /filing pages #514

Open

meissadia opened this issue May 15, 2024 · 0 comments

Assignees

Labels

Collaborator

meissadia commented May 15, 2024 •

edited

Make border configurable in DSR Header component
Update SBL Frontend to use updated DSR
Remove header border in SBL Frontend

Target design

meissadia self-assigned this

meissadia added the mvp label

meissadia mentioned this issue

feat: [PageHeader] Enable/disable bottom border cfpb/design-system-react#350

Merged

meissadia added a commit to cfpb/design-system-react that referenced this issue


feat: [PageHeader] Enable/disable bottom border (#350)

9b8daba

In support of cfpb/sbl-frontend#514

## Changes

- Enable the removal of the bottom border via prop
- Add unit test

## How to test this PR

1. yarn test PageHeader

## Screenshots
### With Border

![screencapture-localhost-6006-2024-05-21-11_09_13](https://github.com/cfpb/design-system-react/assets/2592907/68ffb80e-1c0f-40a3-97a3-ed487504d508)

### Without border

![screencapture-localhost-6006-2024-05-21-11_09_30](https://github.com/cfpb/design-system-react/assets/2592907/e8b12ab3-ccb9-4c95-8b66-6481e0e45fd7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment