Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question marks in filenames prevent cloning repository on Windows #29

Open
chosak opened this issue Dec 1, 2020 · 1 comment
Open

Comments

@chosak
Copy link
Member

chosak commented Dec 1, 2020

The crawl currently saves many URLs with query strings in them, for example the different pages of a search result. This generates filenames with question marks in them, which are not valid on Windows.

Here's a list of these URLs right now, which can be generated with this command:

find www.consumerfinance.gov -name '*?*' -print

Thanks to @csebianlander for discovering this bug.

One potential fix would be to rename these files before committing them to the repo.

@Zaidtech
Copy link

Is this issue still open sir, can I work upon it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants