Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Revise show markup & copy experience #236

Open
scottaohara opened this issue Oct 22, 2018 · 0 comments
Open

Revise show markup & copy experience #236

scottaohara opened this issue Oct 22, 2018 · 0 comments
Labels
needs work not broken. but not necessarily done. more work needed. Style Guide UI Issues pertaining to the style guide ui, not patterns within.

Comments

@scottaohara
Copy link
Contributor

scottaohara commented Oct 22, 2018

I would expect the show markup buttons to act more like toggle buttons rather than their current experience of revealing the markup, but you then can't close it.

When the markup pattern opens, focus doesn't get updated to the new copy button, or get sent to the code pattern.

When the copy button is activated, a "copied" message is visually shown, but not announced. Depending on the screen reader, the code that was revealed may start getting announced (VO) or nothing will be announced (JAWS).

@scottaohara scottaohara added needs work not broken. but not necessarily done. more work needed. Style Guide UI Issues pertaining to the style guide ui, not patterns within. labels Oct 22, 2018
Martskin added a commit to Martskin/a11y-style-guide that referenced this issue Oct 31, 2018
cehfisher added a commit that referenced this issue Nov 6, 2018
@scottaohara scottaohara self-assigned this Nov 13, 2018
@scottaohara scottaohara removed their assignment Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs work not broken. but not necessarily done. more work needed. Style Guide UI Issues pertaining to the style guide ui, not patterns within.
Projects
None yet
Development

No branches or pull requests

1 participant