Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add revisionHistoryLimit to deployment #2177

Open
2 tasks
phelian opened this issue Jun 4, 2024 · 2 comments · May be fixed by cdk8s-team/cdk8s-plus#4691
Open
2 tasks

Add revisionHistoryLimit to deployment #2177

phelian opened this issue Jun 4, 2024 · 2 comments · May be fixed by cdk8s-team/cdk8s-plus#4691
Labels
@component/cdk8s-plus Issue related to cdk8s-plus effort/small 1 day tops feature-request New/Enhanced functionality wanted good-first-issue Good for newcomers priority/p2 Dependent on community feedback. PR's are welcome :)

Comments

@phelian
Copy link

phelian commented Jun 4, 2024

Description of the feature or enhancement:

Add option to set revisionHistoryLimit .spec.revisionHistoryLimit

Use Case:

Default value of 10 replicasets will be selected and one might want to change this.

Proposed Solution:

Adding this to deploymentProps

    /**
     * Number of desired replicasets history.
     *
     * @default 10
     */
    readonly revisionHistoryLimit?: number;

Other:

N/A

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@phelian phelian added feature-request New/Enhanced functionality wanted needs-triage Priority and effort undetermined yet labels Jun 4, 2024
@iliapolo iliapolo added good-first-issue Good for newcomers priority/p2 Dependent on community feedback. PR's are welcome :) effort/small 1 day tops and removed needs-triage Priority and effort undetermined yet labels Jun 6, 2024
@parthlaw
Copy link

Hi @iliapolo this PR fixes this issue. Please review this if anything is remaining. I checked the code of cli and it uses the property names as it is. So we don't need to do any more changes. Please let me know if I missed something.

@parthlaw
Copy link

Did some digging. Added more changes to the PR as required.

@iliapolo iliapolo added the @component/cdk8s-plus Issue related to cdk8s-plus label Sep 20, 2024
@iliapolo iliapolo transferred this issue from cdk8s-team/cdk8s-plus Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@component/cdk8s-plus Issue related to cdk8s-plus effort/small 1 day tops feature-request New/Enhanced functionality wanted good-first-issue Good for newcomers priority/p2 Dependent on community feedback. PR's are welcome :)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants