🐛 Fix stripping of idle qubits #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgholzer
added
refactor
burgholzer
force-pushed
the
fix-idle-qubit-stripping
branch
from
9b64a26 to
f506140
Compare
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
burgholzer
force-pushed
the
fix-idle-qubit-stripping
branch
from
f506140 to
dca4aae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #763 +/- ##
=====================================
Coverage 92.2% 92.2%
=====================================
Files 126 126
Lines 13827 13828 +1
Branches 2153 2153
=====================================
+ Hits 12756 12759 +3
+ Misses 1071 1069 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #729
This PR builds on the register handling improvements in #807 and fixes the the last remaining part of the problem observed in #729.
When dumping a circuit to QASM that has been stripped of idle qubits, the initial layout and output permutation need to be adjusted so that the resulting circuit can be read in again without problems.
The reason this PR is so small is mainly because a lot of the legwork was already done in #807.
Checklist: