Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission denied error when building v.0.3.0 #4

Closed
mKay00 opened this issue Dec 2, 2019 · 5 comments
Closed

Permission denied error when building v.0.3.0 #4

mKay00 opened this issue Dec 2, 2019 · 5 comments

Comments

@mKay00
Copy link
Contributor

mKay00 commented Dec 2, 2019

When I try to build the project with the "make" command, I get the following error:

Scanning dependencies of target z3
[ 3%] Generating z3/lib/libz3.so
/bin/sh: 1: scripts/mk_make.py: Permission denied
CMakeFiles/z3.dir/build.make:60: recipe for target 'z3/lib/libz3.so' failed
make[2]: *** [z3/lib/libz3.so] Error 126
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/z3.dir/all' failed
make[1]: *** [CMakeFiles/z3.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

I tried it in WSL and in a docker container, both with Ubuntu 18.04. If I checkout an older version (v.0.2.1) the build works after a submodule update.

@marcelwa
Copy link
Collaborator

marcelwa commented Dec 2, 2019

Thanks for commenting. Please try to remove the old Z3 build via

rm -rf libs/z3/build

in fiction's root folder before triggering a new build.

@mKay00
Copy link
Contributor Author

mKay00 commented Dec 2, 2019

This doesn't work. I use a fresh clone of the repository (like in my dockerfile in PR #5) with the command

git clone --recursive https://github.com/marcelwa/fiction.git

and then use the commands

cd fiction
mkdir build
cd build
cmake ..
make

If I do this there is no build folder in libs/z3/.

@marcelwa
Copy link
Collaborator

marcelwa commented Dec 3, 2019

Ah I see what the issue might be then. Seems like CMake was unable to detect your Python installation. If you can't make CMake to recognize Python correctly, the following workaround might fix your problem. Navigate to fiction/libs/z3/ and execute

python scripts/mk_make.py --prefix=<PATH_TO_FICTION_FOLDER>/build/z3/
cd build
make
make install

Afterwards, you should be good to build fiction via make fiction in your build folder.

@marcelwa marcelwa pinned this issue Dec 3, 2019
@mKay00
Copy link
Contributor Author

mKay00 commented Dec 3, 2019

With this workaround I am able to build it.

@marcelwa marcelwa closed this as completed Dec 3, 2019
@marcelwa marcelwa reopened this Dec 4, 2019
@marcelwa
Copy link
Collaborator

marcelwa commented Dec 4, 2019

Commit bc3116e should render the workaround unnecessary.

@marcelwa marcelwa closed this as completed Dec 4, 2019
marcelwa added a commit that referenced this issue Feb 3, 2023
…#105)

* new coordinate-converter function

* function to convert siqad-coordinates

* ✨ function to convert siqad-coordinates and tests added

* second iteration of coordinate-converter-functions and documentation added

* Delete siqad_to_cartesian.hpp

* ⚗️ Defect-aware physical design experiment

* ⚗️ Python script to create defective surfaces

* ✨ added siqad namespace to enable negative coordinates

* ✨ added tests for negative coordinates

* 🐛 if-else no required in "to_siqad_coord"

* 🎨 d and z-coordinate as bool

* 🎨 z-coordinate type changed from bool to uint8_t : 1

* Siqad coordinates (#4)

* new coordinate-converter function

* function to convert siqad-coordinates

* ✨ function to convert siqad-coordinates and tests added

* second iteration of coordinate-converter-functions and documentation added

* Delete siqad_to_cartesian.hpp

* ✨ added siqad namespace to enable negative coordinates

* ✨ added tests for negative coordinates

* 🐛 if-else no required in "to_siqad_coord"

* 🎨 d and z-coordinate as bool

* 🎨 z-coordinate type changed from bool to uint8_t : 1

Co-authored-by: Drewniok <[email protected]>

* 🐛 added "const" for return iterator of find function

* 🐛 added "const" for return iterator of find function (#80)

Co-authored-by: Drewniok <[email protected]>
Co-authored-by: Marcel Walter <[email protected]>

* ✨ new constructor for sidb_surface to generate surface with aspect ratio as input

* 🎨 added missing docu for SiQAD coordinates

* 🎨 Adjusted code based on advancements in main

* new constructor for sidb_surface.cpp added (#84)

* ✨ new constructor for sidb_surface to generate a surface from an aspect_ratio

Co-authored-by: Drewniok <[email protected]>
Co-authored-by: Marcel Walter <[email protected]>

* 🎨 Marcel's suggestions updated

* 💚 Workaround for MSVC being petty

* 💚 Prevent experiment from being built if Z3 is disabled

* 💚 Workaround for MSVC being petty

* new layer to store charge states of SiDBs, tests included (#6)

* ✨ new layer to store SiDB charge states

* ✨ new layer to store SiDB charge states, test included

* ✨ new layer to store charge states of SiDBs, test included

* ✨ new layer to store charge states of SiDBs, test included

* 🎨 updated Marcel's suggestions

* 🎨 updated Marcel's suggestions

* 🎨 Marcel's suggestions updated and new traits added

* 🎨 added tests for traits

* 🎨 added cstdint to avoid clang-tidy conflict

* 🎨 reformat code

* 🎨 Marcel's suggestions updated

* 🎨 Marcel's suggestions updated

* 🎨 Marcel's suggestions updated

* 🎨 docu completed (.rst)

Co-authored-by: Drewniok <[email protected]>

* Fiction structure (#13)

* 🎨 several changes

* 🎨 lattice parameters to simulation parameters

* ✨ electrostatic potential between two SiDBs, test is included

* ✨ Siqad coordinates are converted to a coordinate (x,y) on the Si-substrate

* ✨ Distance between two SiDBs on the substrate with given lattice parameters, test included

* ✨ Distance matrix where all inter-distances are stored, test included

* ✨ Potential matrix with test

* ✨ distance and potential matrix

* Delete simulation_init.hpp

* ✨ local potential, test included

* ✨ check for physical validity, tests are included

* ✨ function to calculate the system's total electrostatic potential energy, tests included

* ✨ function to check for physically validity (configuration and population stability)

* ✨ small changes

* ✨ deleted

* ✨ function name "distance_sidb_pair" instead of "distance_SiDB_pair"

* ✨ capital letters replaced

* ✨ changed member names

* 🎨 added last line

* 🎨 put constants header to technology folder

* 🎨 added larger distance for testing

* 🎨 small changes

* 🎨 convert charge configuration to a unique index

* 🎨 convert charge configuration to a unique index and vise versa

* 🎨 convert int charge state to label

* 🎨 Marcel's suggestions updated

* 🎨 small changes

* 🎨 use mutable in lambda caption

* 🎨 small changes

* 🎨 added static_cast

* 🎨 Marcel's suggestions updated

* 🎨 update

* 🎨 todo added

* 🎨 big structure change

* 🎨 deleted unordered_map include

* 🎨 whole structure changed

* 🎨 tests added

* 🎨 implemented ExGs

* 🎨 ExGs finished

* 🎨 ExGs finished and single header files deleted

* 🎨 new simulation approach implemented

* 🎨 simulation works

* 🎨 function to compute the time-to-solution

* 🎨 function to compute the time-to-solution and started to implement experiment

* 🎨 experiment works and result table is printed

* 🎨 ExGS with vector instead of unordered_maps

* 🎨 on the way to implement all with vectors

* 🎨 simulation works

* 🎨 "code cleaning"

* 🎨 small experiments to find performance

* 🎨 performance increased by using reserve and get_potential in next_N function

* 🎨 hourglass gates for benchmarking

* 🎨 trying to improve accuracy

* 🎨 benchmark files added

* 🎨 simulation works and produces DAC data

* 🎨 temperature is implemented

* 🎨 test updated

* 🎨 small changes in different files

* 🎨 functions as seperate headers and test for quicksim added

* 🎨 functions as seperate headers

* 🎨 most of the clang-tidy and SonarLint warnings are solved

* Delete experiments/bestagon/layouts/gates directory

* Delete experiments/bestagon/layouts/defect_robust directory

* 🎨 most of the clang-tidy and SonarLint warnings are solved

* Delete temperature.hpp

* Delete speedsim.hpp

* Delete occupation_function.hpp

* Delete simulation_sidb.cpp

* 🎨 tried to solve most of the clang-tidy and SonarLint warnings.

* 🎨 tried to solve windows building error and remaining clang-tidy errors.

* 🎨 MAXFLOAT corrected.

* 🎨 removed static term from charge functions.

* 🎨 best_energy limit changed back to double

* 🎨 replaced "else if" by else in read_sqd_layout

* 🎨 replaced "const auto" by std::string at file.path(), still trying to fix windows building problems

* 🎨 added const to std::string

* 🎨 using auto keyword

* 🎨 using .string()

* 🎨 comma removed in folder vector

* 🎨 cell<Lyt> replaced by typename Lyt::cell for windows.

* 🎨 include for <fiction_experiments.hpp> changed

* 🎨 another typename added for windows

* 🎨 typename cell<Lyt> changed in sidb_surface

* 🎨 typename coordinate<Lyt> changed in sidb_surface

* 🎨 small change

* 🎨 again <Lyt> change in sidb_surface

* 🎨 auto const replaced by auto const

* 🎨 return EXIT_SUCCESS

* 🎨 return header for exgs

* 🎨 small changes, using EXPERIMENTS_PATH to read benchmark files

* 🎨 small changes to update Marcel's comments

* 🎨 deleted test snippet in exhaustive_ground_state_simulation.cpp

* 🎨 stats pointer for tts function.

* 🎨 copy assignment operator added.

* 🎨 tts and exgs renamed to "time_to_solution" and "exhaustive_ground_state_simulation.hpp", respectively.

* Delete exhaustive_ground_state_simulation_bestagon_gate.cpp

in "cda-tum/sidb-layouts-quicksim-validation" repo

* Delete quicksim_bestagon_gate.cpp

 in cda-tum /sidb-layouts-quicksim-validation repo

* Delete tts_acc_all_bestagon.cpp

in  cda-tum/sidb-layouts-quicksim-validation repo

* 🎨 number of repetitions changed from const int to const uint64_t

---------

Co-authored-by: Drewniok <[email protected]>

* 🔨 new function to get all SiDB positions in nm (x,y).

* 🔨 two functions which are useful for the integration into SiQAD

* 🔨 main merged in groundstate_simulation_sidb

* 🔥 Removed artifact files

* 🎨 Applied ClangFormat

* 🎨 Code formatting

* 🔨 test for time-to-solution added

* 🔨 test for check_groundstate.cpp added

* 🔨 reformat code

* 🎨 Moved files and fixed documentation

* 🎨 Adjusted simulation algorithms to construct their own `charge_distribution_surface` objects

* 🔨 pop_stability added to "is_groundstate.hpp"

* 💚 Fixed compiler errors on template deduction

* 🔨 tts_acc_tss gets cell-level-layout as input.

* 🔨 tts_acc_tss gets quicksim_params as input (includes physical sidb parameters and simulation parameters).

* 🚨 Addressed linter warnings regarding `std::rand()` (which are not wrong)

---------

Co-authored-by: Marcel Walter <[email protected]>
Co-authored-by: Marcel Walter <[email protected]>
Co-authored-by: Drewniok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants