-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Googlebot is shown as iPhone #29
Comments
this is an interesting issue because google bot is using emulation here to look at it through different lenses... the question is do we care if it's the bot or do we care of it's iPhone; somewhat interested in the larger opinion |
We should put it as GoogleBot, as for any analytical purposes, it's GoogleBot. |
@sktnetwork - I can follow that thinking; I'll make some adjustments for 1.9.4 ; thanks. |
@sktnetwork - it will be in 1.9.5 - didn't make it into 1.94 - I ran out of time |
We screwed up our internal analytics by this issue.
Sample Input UserAgent: "Mozilla/5.0 (iPhone; CPU iPhone OS 6_0 like Mac OS X) AppleWebKit/536.26 (KHTML, like Gecko) Version/6.0 Mobile/10A5376e Safari/8536.25 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)"
Output: iPhone.
Expected Output: GoogleBot
Solution / Fix:
The parsing priority for Googlebot (and other bots) must be high.
Replace the function checkBrowsers with this:
The text was updated successfully, but these errors were encountered: