Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Disable react/jsx-curly-brace-presence #41

Open
tetsuharuohzeki opened this issue Mar 4, 2019 · 2 comments
Open

Disable react/jsx-curly-brace-presence #41

tetsuharuohzeki opened this issue Mar 4, 2019 · 2 comments
Labels
A-config AREA: changes related to rules D-stylistic DOMAIN: stylistic issues I-enhancement

Comments

@tetsuharuohzeki
Copy link
Contributor

This rule is too eager. This misses to detect the error and too noisy.

@tetsuharuohzeki tetsuharuohzeki added A-config AREA: changes related to rules I-enhancement labels Mar 4, 2019
@tetsuharuohzeki
Copy link
Contributor Author

see #46

@tetsuharuohzeki
Copy link
Contributor Author

  • For children, I think we enable this. but the current rule impl. is pretty buggy and noisey. It's better to disable it.
  • For props, inn JSX syntax, props is not a string in many cases. And in plain JavaScript worlds, we don't have any static type checks, we need think about whether we should add a bracket or not by the type of props. It's pretty tired thing. For sorting style and avoid this tired thing, I prefer to write bracket always.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-config AREA: changes related to rules D-stylistic DOMAIN: stylistic issues I-enhancement
Projects
None yet
Development

No branches or pull requests

1 participant