Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase file colour contrast for dark flavours (frappe, macchiato & mocha) #134

Open
1 task done
connrs opened this issue May 15, 2024 · 3 comments
Open
1 task done
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@connrs
Copy link

connrs commented May 15, 2024

Is there an existing issue outlining your improvement?

  • I have searched the existing issues and my improvement has not been raised yet.

What would you like to see added and/or changed?

For your consideration: I believe it would be very helpful if the contrast between the Orange and Rose colours when configuring file colors could be widened a little so that they are easier to distinguish.

I use file colors to ensure that different scopes of my projects are highlighted with a traffic light scheme so I can distinguish between low/medium/high risk code.

The orange and rose colours are very close and it is hard for me to distinguish between the two when inside any of the dark mode UI themes (I <3 Frappe when I'm in the mood for dark mode.)

Catpucchin Latte however is chefs kiss as the contrast is wonderful. I'm currently sticking to light mode (oh, the humanity) at the moment as I'm working on a project which requires me to pay attention to this traffic light scheme of scopes.

I appreciate that this may be a difficult request to satisfy as you need to balance contrast with the theme itself.

@connrs connrs added the enhancement New feature or request label May 15, 2024
@connrs connrs changed the title Appearance & Behavior | File Colors: Contrast issue between Orange and Rose Appearance & Behavior | File Colors: Emphasise difference in contrast/hue between Orange and Rose May 15, 2024
@sgoudham
Copy link
Contributor

Hey 👋

Thanks for bringing this to my attention, I don't have file colours enabled so I wasn't aware of it. I'm focusing on other parts of the Catppuccin organisation at the moment but I'd appreciate a PR to increase the contrast for the darker flavours.

I believe the values listed below need to be tweaked:

"FileColor": {
"Blue": "{{isLatte (opacityWithHex blue 0.15) (opacityWithHex blue 0.1)}}",
"Green": "{{isLatte (opacityWithHex green 0.15) (opacityWithHex green 0.1)}}",
"Orange": "{{isLatte (opacityWithHex peach 0.15) (opacityWithHex peach 0.1)}}",
"Rose": "{{isLatte (opacityWithHex red 0.15) (opacityWithHex red 0.1)}}",
"Violet": "{{isLatte (opacityWithHex lavender 0.15) (opacityWithHex lavender 0.1)}}",
"Yellow": "{{isLatte (opacityWithHex yellow 0.15) (opacityWithHex yellow 0.1)}}"

Happy to accept a PR that updates the values listed above and with before/after screenshots!

@sgoudham sgoudham added the good first issue Good for newcomers label May 23, 2024
@sgoudham sgoudham changed the title Appearance & Behavior | File Colors: Emphasise difference in contrast/hue between Orange and Rose Increase file colour contrast for dark flavours (frappe, macchiato & mocha) May 23, 2024
@connrs
Copy link
Author

connrs commented May 29, 2024

Hey @sgoudham,

Thanks for this (especially the hint about what needs altering.)

I will have a look over the next few weeks and see if I can make some adjustments. If I can make it look even half decent then I'll submit a PR and see what you think.

@sgoudham
Copy link
Contributor

No worries! I'm happy to assist if you want to provide updates here.

Make sure to read the CONTRIBUTING.md which should hopefully answer some questions around project setup, also happy to explain anything further in this issue if need be!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants