Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow loading times #127

Closed
Orest58008 opened this issue Oct 28, 2023 · 6 comments
Closed

Slow loading times #127

Orest58008 opened this issue Oct 28, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@Orest58008
Copy link

The theme is really slow to load/enable.
It takes almost twice as much to enable as Zenburn and what feels like thrice as much to take to usable GUI.
Elpaca, straight and package.el all produce roughly the same times, so they're not issue. What may be the issue and how can I attempt to fix it?

@NamesCode
Copy link
Member

I'm unsure what could be leading to this. It could be that our theme uses some internal functions during the loading process, but if thats the case then we'd have to find a way to improve speed without deleting those functions.

Fell free to play around with it tho, if you do manage feel free to open a PR ^^

@NamesCode NamesCode added the enhancement New feature or request label Nov 21, 2023
@rafagil
Copy link
Contributor

rafagil commented Apr 4, 2024

@NamesCode I did a small bit of research on this and I figured the file is not being byte compiled. That leads to the veeeeeery slow loading times. If we remove the no-byte-compile: t flag in the beginning of the file, it loads as quickly as all other themes.
But, maybe that flag is there for a reason? If it was just an oversight, removing it improves the performance by a lot.

@NamesCode
Copy link
Member

I'll see about testing it tomorrow, I don't see why we need to keep no-byte-compile so it should be safe to remove ^^

@NamesCode
Copy link
Member

@Orest58008 Can you test with the new version of the theme?

@Orest58008
Copy link
Author

Unfortunately I can't because I've moved to Neovim due to some weird issues with fonts in GNU Emacs itself

@NamesCode
Copy link
Member

Ah ok, it should be fine regardless ^^. Hope you enjoy Neovim, i've made the switch too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants