Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update existing comment #51

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bojanrajh
Copy link

This PR adds comment_on_pr=update option and closes #48 .

src/post.ts Outdated Show resolved Hide resolved
@serkan-ozal
Copy link
Member

@bojanrajh Look good to me.
@rwxdash Could you please check that as well?

@serkan-ozal serkan-ozal self-requested a review March 2, 2024 10:23
@serkan-ozal
Copy link
Member

@bojanrajh Could you please check style issues by npm run format

@bojanrajh
Copy link
Author

@serkan-ozal Done.

@rwxdash
Copy link
Member

rwxdash commented Mar 4, 2024

Thank you @bojanrajh for the PR. Can you please fix the CI check and run npm run all?

Is it also possible to provide an example workflow run to show that the update comment flow works as expected?

geekgonecrazy added a commit to RocketChat/Rocket.Chat that referenced this pull request Apr 2, 2024
d-gubert added a commit to RocketChat/Rocket.Chat that referenced this pull request Apr 12, 2024
commit 0c93266
Merge: 7aa3136 0fcf1f0
Author: Aaron Ogle <[email protected]>
Date:   Wed Apr 3 16:59:34 2024 +0000

    Merge branch 'develop' into add-metrics-to-actions

commit 7aa3136
Merge: e71dc83 fa9c905
Author: Guilherme Gazzo <[email protected]>
Date:   Tue Apr 2 23:41:33 2024 -0300

    Merge branch 'develop' into add-metrics-to-actions

commit e71dc83
Author: Aaron Ogle <[email protected]>
Date:   Tue Apr 2 16:43:25 2024 +0000

    Add to the two heavy meteor build jobs for some visibility

commit 9d3f6b3
Author: Aaron Ogle <[email protected]>
Date:   Tue Apr 2 16:33:15 2024 +0000

    helps if put in the actual workflow.  Its not even Monday o.o

commit c045379
Author: Aaron Ogle <[email protected]>
Date:   Tue Apr 2 16:18:27 2024 +0000

    setting comment_on_pr to false until catchpoint/workflow-telemetry-action#51 is merged

commit 7d52dc9
Author: Aaron Ogle <[email protected]>
Date:   Tue Apr 2 16:13:06 2024 +0000

    Add telemetry to CI so we can get a better understanding of resource usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reuse existing Telemetry PR comment when new telemetry is executed
3 participants