You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all I want to thank you for a great project!
When have set the retry_on_timeout setting to false (default value) it blocks all request resulting in a ConnectException from being retried. This causes confusion when using the library. I have some suggested solutions of varying degree ROI. I can help with the implementation if you want to, just let me know what solution you prefer.
Just rename retry_on_timeout to retry_on_connection_issue Pros: Small amount of work Cons: Require a major version bump which may be a bit aggressive for such a small change
Introduce a new option called retry_on_connection_issue with a default value of false and deprecating the retry_on_timeout option. Check if ether one is true when deciding if a retry should be done Pros: Keep backwards compatibility Cons: Require the documentation to be clear in order to avoid confusion
There are more possible solutions, please let me know what you think
The text was updated successfully, but these errors were encountered:
Detailed description
First of all I want to thank you for a great project!
When have set the
retry_on_timeout
setting tofalse
(default value) it blocks all request resulting in a ConnectException from being retried. This causes confusion when using the library. I have some suggested solutions of varying degree ROI. I can help with the implementation if you want to, just let me know what solution you prefer.Context
https://github.com/caseyamcl/guzzle_retry_middleware/blob/v2.9.0/src/GuzzleRetryMiddleware.php#L230-L243
Possible implementation
retry_on_timeout
toretry_on_connection_issue
Pros: Small amount of work
Cons: Require a major version bump which may be a bit aggressive for such a small change
retry_on_connection_issue
with a default value offalse
and deprecating theretry_on_timeout
option. Check if ether one is true when deciding if a retry should be donePros: Keep backwards compatibility
Cons: Require the documentation to be clear in order to avoid confusion
There are more possible solutions, please let me know what you think
The text was updated successfully, but these errors were encountered: