Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Automated versioning #171

Open
EmperorYP7 opened this issue Nov 21, 2021 · 4 comments
Open

[CMake] Automated versioning #171

EmperorYP7 opened this issue Nov 21, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@EmperorYP7
Copy link
Member

Description

The version specified in CMake config and the version released by GitHub Actions is not the same and can be really confusing for the clients. We can automate the versioning to coincide the CMake version with the GH version of casbin-cpp through another GitHub Action which should trigger on push to master branch.

@casbin-bot
Copy link
Member

@casbin-bot casbin-bot added the question Further information is requested label Nov 21, 2021
@EmperorYP7 EmperorYP7 added enhancement New feature or request help wanted Extra attention is needed and removed question Further information is requested labels Nov 21, 2021
@hsluoyz
Copy link
Member

hsluoyz commented Nov 21, 2021

@sheny1xuan

@sheny1xuan
Copy link
Contributor

sheny1xuan commented Nov 22, 2021

Good point. But I think it's maybe difficult to do that automatically. Because if we update cmake file atfer a new release, we will generate change in cmakelists.txt. And I can't find a plugin can do that thing. Maybe we can update cmake version with the release rule. This is a very tricky thing. @EmperorYP7

@EmperorYP7
Copy link
Member Author

I'll keep everyone updated once I have a practical approach for this.

@EmperorYP7 EmperorYP7 changed the title Automated versioning [CMake] Automated versioning Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants