Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples should have tests as well #9

Open
staceytay opened this issue Dec 18, 2017 · 4 comments
Open

Examples should have tests as well #9

staceytay opened this issue Dec 18, 2017 · 4 comments

Comments

@staceytay
Copy link
Contributor

staceytay commented Dec 18, 2017

Would like example/echo/service/service.go to have sample tests that shows examples on how to test an Orion service, for both gRPC and http requests.

The context for this is that I'm attempting to write tests for https://github.com/carousell/SSO and so would like to refer to effective and efficient ways to test the service. For example, how to create a test an Orion service with the database functions mocked.

I tried creating a sample service

	service := &ssoServiceImpl{
		true,
		&djangoService{},
		"i63t3cfyumyMY2mY2DLM3HJQKYvGu24H",
		securecookie.New([]byte("i63t3cfyumyMY2mY2DLM3HJQKYvGu24H"), []byte("v6D83W7i6CJc7suVQzEEQPbu6mdNsrW6")),
		&storageClient{},
	}

	req := new(proto.LoginRequest)
	service.Login(ctx, req)

but this doesn't allow me to test for the http response codes and headers

@ankurs
Copy link
Contributor

ankurs commented Dec 18, 2017

Agreed, will take it up once orion is feature complete!
Please feel free to contribute till then

@kapeel-mopkar
Copy link

I am getting error while trying out the examples.

For stringsvc example, in generated file stringproto.proto.orion.pb.go, getting following erro:

cannot use &_StringService_serviceDesc (type *"google.golang.org/grpc".ServiceDesc) as type *"github.com/carousell/Orion/vendor/google.golang.org/grpc".ServiceDesc in argument to orionServer.RegisterServicego

Please advise, thanks

@ankurs
Copy link
Contributor

ankurs commented Jan 17, 2019

Kapeel, this is most likely because of missing vendor package, can you update your vendor and check ?

@kapeel-mopkar
Copy link

@ankurs : pls ignore my earlier comment.

I have got the code working on my windows env. I had to run govendor fetch github.com/carousell/Orion/orion

Thnaks for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants