Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image URLs which are not FQDN and have no size are missed by images() #74

Open
pagojo opened this issue Aug 18, 2014 · 2 comments
Open

Comments

@pagojo
Copy link
Contributor

pagojo commented Aug 18, 2014

eg.,

...
<div id="page">

<div class="article-img">
<img src="/v9/images/1x1-white.jpg" width="660" height="317" alt="iPhone Plus" class="lazy" data-original="/iphoneplus-130205.jpg"><noscript><img src="/iphoneplus-130205.jpg"></noscript>
</div>
<div class="article-img">
<img src="/plus-130906.jpg">
</div>
...

will only return /v9/images/1x1-white.jpg when images() is called.

However, if images_with_fqdn_uris!("http://bla.com") is called then subsequent calls to images() will return an array with all image URLs (fully qualified with http;//bla.com).

Now the question is, what the desired behaviour should be?

@cantino
Copy link
Owner

cantino commented Aug 18, 2014

I suspect you generally want fqdns always.

@pjscopeland
Copy link

Thanks, I couldn't get an image I knew was there either - wouldn't have thought of putting the FQDNs in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants