Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown reason for TEXT_LENGTH_THRESHOLD #54

Open
pagojo opened this issue Nov 13, 2013 · 0 comments
Open

Unknown reason for TEXT_LENGTH_THRESHOLD #54

pagojo opened this issue Nov 13, 2013 · 0 comments

Comments

@pagojo
Copy link
Contributor

pagojo commented Nov 13, 2013

In clean_conditionally(node, candidates, selector) the constant TEXT_LENGTH_THRESHOLD is used which ever being declared.

Do we know what was the intention for this?
pagojo added a commit to pagojo/ruby-readability that referenced this issue Nov 14, 2013
@pagojo
Fixes cantino#51 and cantino#54 to not cull if an image exists in a d…
0c8b56a 
…iv without text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pagojo