Record "recover-service" change when recovering/restarting a service #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow I'd missed this when I added the state diagram originally.
This will enable debugging/introspection on whether a service is failing and being auto-restarted. You can introspect it with the changes API or the "pebble changes" and "pebble tasks" CLI commands. The kind (type) of the changes is "recover" and the kind of the tasks is "restart". Example output while I service is begin recovered (change 3 is not yet ready): $ pebble changes ID Status Spawn Ready Summary 1 Done today at 16:08 NZST today at 16:08 NZST Autostart service "test2" 2 Done today at 16:08 NZST today at 16:09 NZST Recover service "test2" 3 Done today at 16:09 NZST - Recover service "test2" After it's recovered the change is marked done/Ready: $ pebble changes ID Status Spawn Ready Summary 1 Done today at 16:08 NZST today at 16:08 NZST Autostart service "test2" 2 Done today at 16:08 NZST today at 16:09 NZST Recover service "test2" 3 Done today at 16:09 NZST today at 16:10 NZST Recover service "test2" $ pebble tasks 2 Status Spawn Ready Summary Done today at 16:08 NZST today at 16:08 NZST Restart service "test2" Done today at 16:08 NZST today at 16:08 NZST Restart service "test2" Done today at 16:09 NZST today at 16:09 NZST Restart service "test2" $ pebble tasks 3 Status Spawn Ready Summary Done today at 16:09 NZST today at 16:09 NZST Restart service "test2" Fixes canonical#104
benhoyt
changed the title
|
Per above comment, we're likely to use events for this instead. Closing for now (can always reopen later if necessary). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record a "recover" change when recovering a service, and record one task per restart within that.
This will enable debugging/introspection on whether a service is failing and being auto-restarted. You can introspect it with the changes API or the "pebble changes" and "pebble tasks" CLI commands.
The kind (type) of the changes is "recover" and the kind of the tasks is "restart".
Example output while I service is begin recovered (change 3 is not yet ready):
After it's recovered the change is marked done/Ready:
Fixes #104