Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DESIGN] Introduce YAML parser for dealing with yaml config operations #35

Open
Mehdi-Bendriss opened this issue May 7, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Mehdi-Bendriss
Copy link
Contributor

Currently YAML related operations (read / write) is handled as plain text operations.
We should use proper yaml parsing when dealing with yaml documents.

Copy link

github-actions bot commented May 7, 2024

@Mehdi-Bendriss Mehdi-Bendriss added the bug Something isn't working label May 7, 2024
@juditnovak juditnovak changed the title Introduce YAML parser for dealing with yaml config operations [DESIGN] Introduce YAML parser for dealing with yaml config operations May 7, 2024
@juditnovak
Copy link
Contributor

juditnovak commented May 7, 2024

IGNORE, discussed live, see conclusion in the next comment

--

This was a design decision that have been discussed multiple times.

I see no need for YAML operations in the current layout (and I'm not the only one with that view in the Data Platform Team).

Aslo, may I ask why would you label a known design decision would as a bug ...?

Is there a missing functionality that can not be fullfilled with the current method?

In other words: what is the purpose of this open issue? What is the problem we are trying to resolve?

(Part of the reason why I'm asking is because we have a few burning issues around the Dashboards...)

@juditnovak
Copy link
Contributor

Conclusion: we agreed offline, that as long as pyyaml could allow for a simple solution (i.e. not "re-inventing the wheel") it could be a good balance to allow for config management. Taking it up from here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants