You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should consider extracting the logic of expiring into some method renew_certificates or similar and call it from here as well as from _on_certificate_expiring.
The reason being that this is now fine, but only because we are not making use of the event: CertificateExpiringEvent that's normally passed as an argument of _on_certificate_expiring.
We are not using the event by policy . It's not a co-incidence.
The charm was doing this before the particular modification that triggered this thread (see _set_tls_private_key()).
My question is: are there any risks implied by the current policy?
juditnovak
changed the title
Extract logic for certificate renewal to its own separate method
[DESIGN] Extract logic for certificate renewal to its own separate method
May 7, 2024
Context of issue here #22 (comment)
The text was updated successfully, but these errors were encountered: