Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DESIGN] IP Address change should be checked based on the rendered opensearch_dashboards.yml #27

Open
Mehdi-Bendriss opened this issue May 6, 2024 · 5 comments

Comments

@Mehdi-Bendriss
Copy link
Contributor

Context for issue: #22 (comment)

Copy link

github-actions bot commented May 6, 2024

@juditnovak
Copy link
Contributor

Is there a specific reason for this request? I mean what is the problem, or currently broken/mssing feature that we are trying to solve with this?

@juditnovak
Copy link
Contributor

Part of the reason why I'm asking is the following: the Dasboard is missing core features and core checks right now, like

  • upgrades
  • status change when the service is down,
  • etc

While perfectly responds to all expected functionality and stress test.

@juditnovak
Copy link
Contributor

...also please note that the requested check is redundant thus not missing.

On each reconcile() handler exectu (that's executed on all charm-level base events):

  • in case TLS is available and configured on the unit we confirm that the certificate is valid and corresponds to the host IP
  • we check if the config corresponds to the host's IP, and perform a re-configure (and the mandatory restart) in case it's not.

@juditnovak juditnovak changed the title IP Address change should be checked based on the rendered opensearch_dashboards.yml [DESIGN] IP Address change should be checked based on the rendered opensearch_dashboards.yml May 7, 2024
@juditnovak
Copy link
Contributor

My most important question here is: what kind of action do we want to take based on the IP in the config?

The reason why I'm asking is because the IP change in the config is rather an "end result" of a process, than the cause/origin.

What I mean is: typically under certain circumstances we decide to change the IP in the config.

What I would like to understand here is why would we want to know the status of the config file, i.e. what kind of actions may (or may not) be done based on the actual state of the config file? In other words: assuming we implement this check -- what would we do with the information that comes out of it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants