New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"microk8s status" exits with zero return code when server is down #3974
Labels
Comments
3 tasks
Hey @rsalinas, thanks for opening the issue and the PR. I'll try to look into it soon. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
microk8s status returns 0 when the server is down.
$ microk8s status --yaml ; echo $?
microk8s is not running, try microk8s start
0
What Should Happen Instead?
I would expect it to return non-zero, so that I don't need to search for text in the output.
This also complicates my life when trying to directly parse its output as yaml.
Reproduction Steps
Introspection Report
Probably not relevant.
Can you suggest a fix?
Yes, simply return non-zero when the server is down.
Fix scripts/wrappers/common/utils.py:
Are you interested in contributing with a fix?
Yes, it's about changing that zero by a one.
I can make a PR if you wish.
The text was updated successfully, but these errors were encountered: