-
Notifications
You must be signed in to change notification settings - Fork 4
#106 Remove unused one line helpers #111
base: master
Are you sure you want to change the base?
Conversation
@@ -141,256 +141,21 @@ | |||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still references in the text above to the classes you've removed.
*/ | ||
|
||
.h-clear-fix { | ||
@include clear-fix(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the mixin also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you also be able to remove this mixin also (and its comments)?
@mixin text-osx-font-smoothing($apply-important-keyword: false) {
$important-keyword: if($apply-important-keyword, ' !important', '');
-moz-osx-font-smoothing: grayscale#{$important-keyword};
-webkit-font-smoothing: antialiased#{$important-keyword};
}
@include apply-at-breakpoints('.h-text-align-right', $shell-helper-define-text-align-right-breakpoints) { | ||
text-align: right !important; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all the related settings also.
@DaveOrDead please make sure you've followed the applicable steps here: https://github.com/campaignmonitor/shell/blob/master/CONTRIBUTING.md#steps-for-contributing-code-to-shell. Also once this gets merged to |
Fixes #106 also included clearfix as that hasn't been used at all since introducing flexbox
@chris-pearce