feat: Allow browser to be specified #757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of making the assumption on behalf of the user, allow them to control the browser which is used for the debugger UI. This is controlled via the `RCT_DEBUGGER_BROWSER` environment variable. If this variable is populated, then it will be tried first, before falling back to the baked-in defaults.
|
I haven't looked into how to test this in an automated way, but I can if it agreed that this is a valid approach. |
evancharlton
commented
Oct 21, 2020
| }, | ||
| ]; | ||
|
|
||
| // If the user has provided a specific browser preference, try that one first. |
There was a problem hiding this comment.
There's certainly an argument to be made for not doing a fallback if the user has specified a preference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of making the assumption on behalf of the user, allow them to
control the browser which is used for the debugger UI. This is
controlled via the
RCT_DEBUGGER_BROWSERenvironment variable. If thisvariable is populated, then it will be tried first, before falling back
to the baked-in defaults.
Test plan
This can be tested by setting
RCT_DEBUGGER_BROWSERto another browserand then running the
startcommand for the@haul-bundler/clipackage.
Issues
This addresses issue #756