Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sender ID info not being shown on 'info' hover in 'add action' flow #14874

Closed
utkershrajvenshi opened this issue May 4, 2024 · 2 comments 路 Fixed by #14879
Closed

Sender ID info not being shown on 'info' hover in 'add action' flow #14874

utkershrajvenshi opened this issue May 4, 2024 · 2 comments 路 Fixed by #14879
Labels
馃悰 bug Something isn't working workflows area: workflows, automations

Comments

@utkershrajvenshi
Copy link
Contributor

Found a bug? Please fill out the sections below. 馃憤

Issue Summary

On hovering over the 'info' icon in the ActionDialog component, a proper information should be shown, as fixed recently in PR #14846 . The same behaviour should be applied to AddActionDialog component.

Steps to Reproduce

  1. In 'Workflows' -> Create a new workflow or edit a existing one
  2. Click on 'Add action' to render AddActionDialog component
  3. Select action as 'Send SMS to attendee'
  4. Notice that on hovering over info icon next to Sender ID label nothing happens

Actual Results

  • Doesn't show extra information when hovered on
    Screenshot from 2024-05-04 18-03-19

Expected Results

Technical details

  • Browser version: Chrome v123.0.6312.58
  • Node.js version: v20.12.2

Evidence

@utkershrajvenshi
Copy link
Contributor Author

Team, I'd like to contribute to this issue fix.

@dosubot dosubot bot added workflows area: workflows, automations 馃悰 bug Something isn't working labels May 4, 2024
Copy link

dosubot bot commented May 4, 2024

To tackle the tooltip issue in the AddActionDialog component, start by examining the implementation from PR #14846, focusing on how the tooltip functionality was integrated. This will give you a solid foundation for applying a similar fix to the AddActionDialog component.

  1. Review PR fix: Sender ID info not shown on hover聽#14846: Understand the changes made, especially how tooltips were added or modified. Note any new libraries, utilities, and adjustments to component props or state.

  2. Examine AddActionDialog Implementation: Identify how information display is currently handled and what adjustments are needed to support tooltip display on hover.

  3. Implement Tooltip Functionality: Ensure your implementation aligns with the project's standards, making the tooltip's appearance and behavior consistent with the established fix.

  4. Test Your Changes: Verify functionality in Chrome v123.0.6312.58 and with Node.js version v20.12.2, ensuring the tooltip appears correctly without causing regressions in the AddActionDialog component.

  5. Submit Your Changes: Follow the project's contribution guidelines to create a new branch, commit your changes, and open a pull request for review. Provide a clear description of your changes, referencing the original issue and PR fix: Sender ID info not shown on hover聽#14846 to help maintainers understand the context of your fix.

This approach ensures your contribution is aligned with the project's needs and facilitates a smoother review process by the maintainers.

Details

Sources


About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 馃憤 if this is helpful and 馃憥 if it is irrelevant.

To continue the conversation, mention @dosu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悰 bug Something isn't working workflows area: workflows, automations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant