Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processes down doesn't stop processes #1210

Closed
shishkin opened this issue May 16, 2024 · 2 comments
Closed

processes down doesn't stop processes #1210

shishkin opened this issue May 16, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@shishkin
Copy link

Describe the bug
I have a process defined via processes.{name}.exec. When I run it with devenv up -d and then do devenv processes down it keeps running.

To reproduce

Snippet from devenv.nix:

  processes.my_container = {
    exec = "docker run --rm --name my_container my_container";
    process-compose = {
      shutdown.command = "docker stop my_container";
    };

Run with devenv up -d then devenv processes down.

See container still running with docker ps

Version

devenv 1.0.5 (aarch64-darwin)

@shishkin shishkin added the bug Something isn't working label May 16, 2024
@sandydoo
Copy link
Member

sandydoo commented May 22, 2024

@shishkin, I tested this with the nginx image and the container shut down correctly. The only time it fails to do so is if I run docker run with the -d detached flag and keep process_compose.is_daemon = false. Could there be something else to this?

@shishkin
Copy link
Author

Hmm... Now it stops in my environment as well. Never mind, maybe I didn't wait long enough as the process command tend to exit before the process stops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants