-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type.cpp missing a few AST descriptions #85
Comments
What is missing exactly? Is the debug print of the AST incomplete? |
In some cases the debug printout has a TODO in it. It’s very unclear to me what’s missing (and probably other contributors would be similarly confused.
I’m on a quest investigating all of the todos so we can get most of them closed as they sometimes come back to haunt you when implementing/fixing something unrelated.
|
For this, it’s just debug printouts that needs to have their todos resolved.
|
There's a lot of (minor) stuff missing. But we have quite some coverage with unit tests, so that's okey. So any new functionality will also have to be supported by tests. |
Can we please not close these unless done? The whole point was to have a list of things that’s needed to do. Unless you just fixed it in a check in. This issue should stay until resolved.
|
Sure, but please don't open an issue for every TODO in the code.. |
:D I promise. The point of opening this one was that I didn't feel able to resolve it myself. I was unsure what you were planning in terms of extending the debug information. If there was a bit of discussion / docs around the TODO / functionality – or it is actually breaking functionality, then I can just go ahead and fix it. |
Struct, Enum, Function and ModuleType is missing debug descriptions.
I think @bvdberg is best suited to decide what should go into those.
The text was updated successfully, but these errors were encountered: