Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type.cpp missing a few AST descriptions #85

Open
lerno opened this issue Dec 5, 2018 · 7 comments
Open

Type.cpp missing a few AST descriptions #85

lerno opened this issue Dec 5, 2018 · 7 comments

Comments

@lerno
Copy link
Collaborator

lerno commented Dec 5, 2018

Struct, Enum, Function and ModuleType is missing debug descriptions.

I think @bvdberg is best suited to decide what should go into those.

@bvdberg
Copy link
Member

bvdberg commented Dec 10, 2018

What is missing exactly? Is the debug print of the AST incomplete?

@lerno
Copy link
Collaborator Author

lerno commented Dec 10, 2018 via email

@lerno
Copy link
Collaborator Author

lerno commented Dec 10, 2018 via email

@bvdberg
Copy link
Member

bvdberg commented Dec 10, 2018

There's a lot of (minor) stuff missing. But we have quite some coverage with unit tests, so that's okey. So any new functionality will also have to be supported by tests.

@bvdberg bvdberg closed this as completed Dec 10, 2018
@lerno
Copy link
Collaborator Author

lerno commented Dec 10, 2018 via email

@bvdberg
Copy link
Member

bvdberg commented Dec 10, 2018

Sure, but please don't open an issue for every TODO in the code..

@bvdberg bvdberg reopened this Dec 10, 2018
@lerno
Copy link
Collaborator Author

lerno commented Dec 10, 2018

:D I promise. The point of opening this one was that I didn't feel able to resolve it myself. I was unsure what you were planning in terms of extending the debug information. If there was a bit of discussion / docs around the TODO / functionality – or it is actually breaking functionality, then I can just go ahead and fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants