addVolumeListener is not triggered on iOS 15 beta #134

badrey · 2021-09-20T18:29:08Z

Package:
"react-native-system-setting": "1.7.6".

Platform:
iOS

OS version:
15.0 beta

Issue:

SystemSetting.addVolumeListener listener is called when physical volume buttons are pressed on a device.

gitmazzio · 2021-09-27T07:03:12Z

Follow the thread.

Also on iOS 15 official release addVolumeListener is NOT triggered when physical volume buttons are pressed on a device.

Package:
"react-native-system-setting": "^1.7.6",
"react-native": "^0.64.2",

EWTDTHK2 · 2021-10-03T16:13:20Z

Based on the following thread
https://stackoverflow.com/questions/68249775/system-volume-change-observer-not-working-on-ios-15

I am testing the KVO method:
in RTCSystemSetting.m
Replace the following

        [[NSNotificationCenter defaultCenter] addObserver:self
                                                 selector:@selector(volumeChanged:)
                                                     name:@"AVSystemController_SystemVolumeDidChangeNotification"
                                                   object:nil];

With:

        AVAudioSession* audioSession = [AVAudioSession sharedInstance];

        [audioSession setActive:YES error:nil];
        [audioSession addObserver:self
                       forKeyPath:@"outputVolume"
                          options:NSKeyValueObservingOptionNew | NSKeyValueObservingOptionOld
                          context:nil];

Add:

- (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(NSDictionary<NSString *,id> *)change context:(void *)context
{

    if (object == [AVAudioSession sharedInstance] && [keyPath isEqualToString:@"outputVolume"]) {
        float newValue = [change[@"new"] floatValue];
        //float old = [change[@"old"] floatValue];
        if (hasListeners) {
                [self sendEventWithName:@"EventVolume" body:@{@"value": [NSNumber numberWithFloat:newValue]}];
        }
    }
}

The above changes are based on https://stackoverflow.com/questions/43361599/react-native-catch-volume-buttons-press-not-for-volume-adjusting/43361738#43361738

Should work on iOS 15, but when the Volume is at max or min pressing the volume up or volume down button again will not trigger the event.

Vollkorn01 · 2021-10-04T14:05:51Z

@EWTDTHK2 Thanks for your fix. It works, but I do get an error when long-pressing the volume button:

Illegal callback invocation from native module. This callback type only permits a single invocation from native code

I understand this problem, but don't know how to fix this, if anybody could help, that would be greatly appreciated.

EWTDTHK2 · 2021-10-04T17:40:29Z

@Vollkorn01
I tried to long press the physical button but I can't reproduce the error that you have encounter yet. However I double checked the original VolumeChanged code. It seems it need to check if the skipSetVolumeCount==0 to prevent setVolume method to trigger the event, perhaps it might be necessary to include this checking.

- (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(NSDictionary<NSString *,id> *)change context:(void *)context
{

    if (object == [AVAudioSession sharedInstance] && [keyPath isEqualToString:@"outputVolume"]) {
        float newValue = [change[@"new"] floatValue];
        if (skipSetVolumeCount == 0 && hasListeners) {
                [self sendEventWithName:@"EventVolume" body:@{@"value": [NSNumber numberWithFloat:newValue]}];
        }
        if (skipSetVolumeCount > 0) {
                skipSetVolumeCount--;
        }
    }
}

Vollkorn01 · 2021-10-05T09:47:01Z

Thanks for your quick reply @EWTDTHK2. I think it is actually related to another native module of mine, sorry for the confusion!

pke · 2021-10-05T22:01:34Z

Is this still a problem in the final iOS 15 version?

normenster · 2021-10-06T15:05:42Z

yes

Vollkorn01 · 2021-10-08T16:30:05Z

I have another issue: When putting the app to the background and opening it again, the listener won't get called anymore. I could reproduce the problem with a freshly initiated react native project. No error logs appear in XCode. Do you have the same problem @EWTDTHK2 ? Appreciate any leads..

EWTDTHK2 · 2021-10-16T17:44:33Z

I have another issue: When putting the app to the background and opening it again, the listener won't get called anymore. I could reproduce the problem with a freshly initiated react native project. No error logs appear in XCode. Do you have the same problem @EWTDTHK2 ? Appreciate any leads..

Didn't notice that until you pointed it out, thx for finding this problem. It seems I got the same issue also. I will see how to fix this.

EWTDTHK2 · 2021-10-16T20:05:37Z

In responds to @Vollkorn01 issue with app going to background and listener does not work when going back to foreground, I am testing the following changes, please kindly help to see if it works. Feel free to let me know if there are other issues.
Replace:

  [[NSNotificationCenter defaultCenter] addObserver:self
                                                 selector:@selector(volumeChanged:)
                                                     name:@"AVSystemController_SystemVolumeDidChangeNotification"
                                                   object:nil];

With:

        [[NSNotificationCenter defaultCenter] addObserver:self
                                         selector:@selector(addVolumeListener:)
                                             name:UIApplicationDidBecomeActiveNotification
                                           object:nil];

Add:

- (void)addVolumeListener:(NSNotification *)notification {
        NSLog(@"AddVolumeListener");
        AVAudioSession* audioSession = [AVAudioSession sharedInstance];

        [audioSession setActive:YES error:nil];
        [audioSession addObserver:self
                       forKeyPath:@"outputVolume"
                          options:NSKeyValueObservingOptionNew | NSKeyValueObservingOptionOld
                          context:nil];
}
- (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(NSDictionary<NSString *,id> *)change context:(void *)context
{

    if (object == [AVAudioSession sharedInstance] && [keyPath isEqualToString:@"outputVolume"]) {
        float newValue = [change[@"new"] floatValue];
        if (skipSetVolumeCount == 0 && hasListeners) {
                [self sendEventWithName:@"EventVolume" body:@{@"value": [NSNumber numberWithFloat:newValue]}];
        }
        if (skipSetVolumeCount > 0) {
                skipSetVolumeCount--;
        }
    }
}

ionleu · 2021-10-19T19:17:10Z

Have same issue,
tried @EWTDTHK2 solution, but facing a build error.

pke · 2021-10-20T22:11:34Z

could be an outdated xcode?

AftabUfaq · 2021-10-21T13:54:19Z

Have same issue,
tried @EWTDTHK2 solution, but facing a build error.

same issue. any solution for this

EWTDTHK2 · 2021-10-23T15:07:42Z

@AftabUfaq and @ionleu do you mind posting the full log of your compilation, I can't see which line the compiler shows where the error is located in this screen shot.

redefinered · 2021-10-25T10:09:03Z

Same issue is happening with my project. Anyone resolved it yet?

ionleu · 2021-10-25T21:02:45Z

error build.pdf

@EWTDTHK2 check this

PS: Thank you for looking into that

EWTDTHK2 · 2021-10-25T23:19:11Z

error build.pdf

@EWTDTHK2 check this

PS: Thank you for looking into that

Please try to add the following line:

#import <AVFoundation/AVFoundation.h>

below

#import <net/if.h>

see if it works?

ionleu · 2021-10-26T20:07:33Z

@EWTDTHK2

Seems that now build process was successful, but still no effects, listener and getVolume is working only on Android

EWTDTHK2 · 2021-10-28T17:40:41Z

@EWTDTHK2

Seems that now build process was successful, but still no effects, listener and getVolume is working only on Android

by the way are you testing on simulator or real device? this only works on real device as far as I know it might not work on simulator.

ionleu · 2021-10-29T00:11:36Z

@EWTDTHK2 ohh, testing on simulator, I'll test then on next week on real device. Thanks

ionleu · 2021-11-02T18:11:00Z

@EWTDTHK2 Tested on iPhone 12, iOS: 15.0.2, works like a charm. Thank you for your help.

gitmazzio · 2021-11-09T11:32:49Z

It works @EWTDTHK2!

Vollkorn01 · 2021-11-12T16:46:12Z

Thank you so much for your fix @EWTDTHK2 , it worked! Another issue I recognized is, when audio is playing (spotify in my case) and I open the app with the fix, the music stops. Do you have the same issue?

EWTDTHK2 · 2021-11-12T18:23:38Z

Thank you so much for your fix @EWTDTHK2 , it worked! Another issue I recognized is, when audio is playing (spotify in my case) and I open the app with the fix, the music stops. Do you have the same issue?

I didn't test this yet, but I think it could likely have this issue. As both app trying to access the AVAudioSession resource. Did you try to disable this fix and see if the music would stops? If you go back to Spotify would you be able to start the music again?

Vollkorn01 · 2021-11-17T16:38:36Z

@EWTDTHK2
Did you try to disable this fix and see if the music would stops?
If I disable the fix, the music doesn't stop.

If you go back to Spotify would you be able to start the music again?
Yes, If I go back to spotify, I can start the music again.

But if I'm in the app and pull down the drawer and press play, it doesn't play. So as long as I'm in the app, I cannot play music. But to be honest, this is not a big issue for our app.

There is another, more pressing issue for our app:
The volume listener doesn't work, when the volume is at minimum or maximum value (and the down button / up button is pressed).

Thanks for your continuous improvements, very appreciated!

EWTDTHK2 · 2021-11-17T17:29:04Z

@EWTDTHK2 Did you try to disable this fix and see if the music would stops? If I disable the fix, the music doesn't stop.

If you go back to Spotify would you be able to start the music again? Yes, If I go back to spotify, I can start the music again.

But if I'm in the app and pull down the drawer and press play, it doesn't play. So as long as I'm in the app, I cannot play music. But to be honest, this is not a big issue for our app.

There is another, more pressing issue for our app: The volume listener doesn't work, when the volume is at minimum or maximum value (and the down button / up button is pressed).
I haven't come up with a better solution to this issue yet.
However, for our app, the volume is triggered by a photo taking remote control and fortunately, there are some bluetooth remote that would set vol up with one click and vol down with another click, which helped us to get around this issue.

Thanks for your continuous improvements, very appreciated!
You are welcome.

SpQuyt · 2021-12-20T08:30:12Z

Anyone merge this Pull Request to make this library work for ios 15 please?

kot331107 · 2022-02-16T01:02:37Z

vote for merging the PR #139 to let everybody use this fix. patch-package is not a pretty legit solution.

pke · 2022-02-16T08:56:13Z

@c19354837 could you please check and merge or give some other contributors merge rights?

[FIX] #134 addVolumeListener is not triggered on iOS 15

c19354837 · 2022-02-16T14:11:23Z

I'm late. I've publish 1.8.0-alpha.0, and you can install by npm install react-native-system-setting@alpha.

stereodenis · 2022-08-19T10:55:08Z

@c19354837 your listener triggered on every second time. So, now there are some skips

arjun-mavonic · 2022-12-25T20:03:51Z

In responds to @Vollkorn01 issue with app going to background and listener does not work when going back to foreground, I am testing the following changes, please kindly help to see if it works. Feel free to let me know if there are other issues. Replace:

  [[NSNotificationCenter defaultCenter] addObserver:self
                                                 selector:@selector(volumeChanged:)
                                                     name:@"AVSystemController_SystemVolumeDidChangeNotification"
                                                   object:nil];

With:

        [[NSNotificationCenter defaultCenter] addObserver:self
                                         selector:@selector(addVolumeListener:)
                                             name:UIApplicationDidBecomeActiveNotification
                                           object:nil];

Add:

- (void)addVolumeListener:(NSNotification *)notification {
        NSLog(@"AddVolumeListener");
        AVAudioSession* audioSession = [AVAudioSession sharedInstance];

        [audioSession setActive:YES error:nil];
        [audioSession addObserver:self
                       forKeyPath:@"outputVolume"
                          options:NSKeyValueObservingOptionNew | NSKeyValueObservingOptionOld
                          context:nil];
}
- (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(NSDictionary<NSString *,id> *)change context:(void *)context
{

    if (object == [AVAudioSession sharedInstance] && [keyPath isEqualToString:@"outputVolume"]) {
        float newValue = [change[@"new"] floatValue];
        if (skipSetVolumeCount == 0 && hasListeners) {
                [self sendEventWithName:@"EventVolume" body:@{@"value": [NSNumber numberWithFloat:newValue]}];
        }
        if (skipSetVolumeCount > 0) {
                skipSetVolumeCount--;
        }
    }
}

@EWTDTHK2 , Thanks you solution really helped. But every time my apps goes into background and then foreground, It's creating more listeners.

INFO  Volume button pressed {"value": 0.949999988079071} 0.949999988079071
INFO  Volume button pressed {"value": 0.949999988079071} 0.949999988079071
INFO  Volume button pressed {"value": 0.949999988079071} 0.949999988079071
INFO  Volume button pressed {"value": 0.949999988079071} 0.949999988079071
INFO  Volume button pressed {"value": 1} 1
INFO  Volume button pressed {"value": 1} 1
INFO  Volume button pressed {"value": 1} 1
INFO  Volume button pressed {"value": 1} 1

dquessenberry · 2023-10-26T23:19:02Z

@c19354837 do you plan to publish a new version with this fix? It's been a while, so I'm just curious. Thanks!

Igor-Tiukavkin added a commit to Igor-Tiukavkin/react-native-system-setting that referenced this issue Nov 3, 2021

[FIX] c19354837#134 addVolumeListener is not triggered on iOS 15

9729eb2

Igor-Tiukavkin mentioned this issue Nov 3, 2021

[FIX] #134 addVolumeListener is not triggered on iOS 15 #139

Merged

c19354837 added a commit that referenced this issue Feb 16, 2022

Merge pull request #139 from Igor-Tiukavkin/fix/iOS15-AddVolumeListener

e1d7a28

[FIX] #134 addVolumeListener is not triggered on iOS 15

stereodenis mentioned this issue Aug 19, 2022

[Feature Request] Volume change listener doublesymmetry/react-native-track-player#1655

Closed

amalmohann mentioned this issue Dec 7, 2022

Event Listeners are not working. Callback functions are not executing and returning anything. [ios] #154

Open

olegderecha mentioned this issue Feb 13, 2023

volume up and Volume down listner not working on ios 15 and above version. is there any solution for this? #153

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

addVolumeListener is not triggered on iOS 15 beta #134

addVolumeListener is not triggered on iOS 15 beta #134

badrey commented Sep 20, 2021

gitmazzio commented Sep 27, 2021

EWTDTHK2 commented Oct 3, 2021

Vollkorn01 commented Oct 4, 2021

EWTDTHK2 commented Oct 4, 2021

Vollkorn01 commented Oct 5, 2021

pke commented Oct 5, 2021

normenster commented Oct 6, 2021

Vollkorn01 commented Oct 8, 2021

EWTDTHK2 commented Oct 16, 2021

EWTDTHK2 commented Oct 16, 2021

ionleu commented Oct 19, 2021

pke commented Oct 20, 2021

AftabUfaq commented Oct 21, 2021

EWTDTHK2 commented Oct 23, 2021

redefinered commented Oct 25, 2021

ionleu commented Oct 25, 2021 •

edited

EWTDTHK2 commented Oct 25, 2021

ionleu commented Oct 26, 2021 •

edited

EWTDTHK2 commented Oct 28, 2021

ionleu commented Oct 29, 2021

ionleu commented Nov 2, 2021

gitmazzio commented Nov 9, 2021

Vollkorn01 commented Nov 12, 2021

EWTDTHK2 commented Nov 12, 2021

Vollkorn01 commented Nov 17, 2021 •

edited

EWTDTHK2 commented Nov 17, 2021

SpQuyt commented Dec 20, 2021

kot331107 commented Feb 16, 2022

pke commented Feb 16, 2022

c19354837 commented Feb 16, 2022

stereodenis commented Aug 19, 2022

arjun-mavonic commented Dec 25, 2022

dquessenberry commented Oct 26, 2023

addVolumeListener is not triggered on iOS 15 beta #134

addVolumeListener is not triggered on iOS 15 beta #134

Comments

badrey commented Sep 20, 2021

gitmazzio commented Sep 27, 2021

EWTDTHK2 commented Oct 3, 2021

Vollkorn01 commented Oct 4, 2021

EWTDTHK2 commented Oct 4, 2021

Vollkorn01 commented Oct 5, 2021

pke commented Oct 5, 2021

normenster commented Oct 6, 2021

Vollkorn01 commented Oct 8, 2021

EWTDTHK2 commented Oct 16, 2021

EWTDTHK2 commented Oct 16, 2021

ionleu commented Oct 19, 2021

pke commented Oct 20, 2021

AftabUfaq commented Oct 21, 2021

EWTDTHK2 commented Oct 23, 2021

redefinered commented Oct 25, 2021

ionleu commented Oct 25, 2021 • edited

EWTDTHK2 commented Oct 25, 2021

ionleu commented Oct 26, 2021 • edited

EWTDTHK2 commented Oct 28, 2021

ionleu commented Oct 29, 2021

ionleu commented Nov 2, 2021

gitmazzio commented Nov 9, 2021

Vollkorn01 commented Nov 12, 2021

EWTDTHK2 commented Nov 12, 2021

Vollkorn01 commented Nov 17, 2021 • edited

EWTDTHK2 commented Nov 17, 2021

SpQuyt commented Dec 20, 2021

kot331107 commented Feb 16, 2022

pke commented Feb 16, 2022

c19354837 commented Feb 16, 2022

stereodenis commented Aug 19, 2022

arjun-mavonic commented Dec 25, 2022

dquessenberry commented Oct 26, 2023

ionleu commented Oct 25, 2021 •

edited

ionleu commented Oct 26, 2021 •

edited

Vollkorn01 commented Nov 17, 2021 •

edited