Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*(reverted)* Issue 128 replace regex engine #133

Merged
merged 4 commits into from
Nov 26, 2020

Conversation

eldipa
Copy link
Collaborator

@eldipa eldipa commented Nov 25, 2020

Closes #128

This introduces a non-compatible change: the next version will have to
be 10.x.x.

Not only we are adding a new dependency but also 'regex' requires a
compiler to be built.
Use a home-made regex module to replace Python's re. This home-made
delegates on the third-party regex module the real work: the only
purpose is to serve as a thin layer between client code and the real
regex engine.

Supports only compile and escape to promote the use the regex/pattern
objects instead of the global functions search/match/find/sub/...
@eldipa eldipa force-pushed the Issue-128-Replace-regex-engine branch from 0713123 to 790e0d1 Compare November 26, 2020 13:29
Pexpect checks explicitly for Python's regexs rejecting Barnett's one.
The adapter closes the gap between this two and allow to use Barnett's
regex with pexpect.
@eldipa eldipa force-pushed the Issue-128-Replace-regex-engine branch from 790e0d1 to e03fff6 Compare November 26, 2020 13:33
@eldipa eldipa merged commit 483c17c into master Nov 26, 2020
@eldipa eldipa deleted the Issue-128-Replace-regex-engine branch November 26, 2020 13:38
@eldipa eldipa restored the Issue-128-Replace-regex-engine branch March 5, 2021 02:20
eldipa added a commit that referenced this pull request Mar 5, 2021
…ex-engine"

This reverts commit 483c17c, reversing
changes made to c636c12.
@eldipa
Copy link
Collaborator Author

eldipa commented Mar 5, 2021

Merge branch onto master reverted in fc9b1c4 due the performance regression.

@eldipa eldipa changed the title Issue 128 replace regex engine **(reverted)** Issue 128 replace regex engine Mar 5, 2021
@eldipa eldipa changed the title **(reverted)** Issue 128 replace regex engine *(reverted)* Issue 128 replace regex engine Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the regex package in replacement of the built-in re module
1 participant