-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to proxy server-sent events (SSE) / event stream #232
Comments
I actually encountered the same issue in oauth2_proxy and think i made a similar patch which may have worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The SSO proxy does not handle upstream server-sent events (SSE) /
text/event-stream
. SSO proxy attempts to handle the request before failing with:ReverseProxy read error during body copy: context deadline exceeded
.A workaround for now is setting a low flush interval:
A potential fix is probably to flush immediately if the content-type matches
text/event-stream
: golang/go@5440bfc#diff-d863507a61be206d112f6e00e6d812a2R342To Reproduce
Steps to reproduce the behavior:
EventSource
to receive automatic updates from a "server" behind SSO proxy (in our case, we are proxying https://argoproj.github.io/argo/ UI)Expected behavior
Any automatic updates (real-time) should be received on the client side.
Screenshots
N/A
Desktop (please complete the following information):
Smartphone (please complete the following information):
N/A
Additional context
We are using
buzzfeed/sso:v1.2.0
on Kubernetes 1.13.The problem is likely related to golang/go#27816. Though, when we recompiled SSO proxy with the latest version of Go (which should have the fix for the linked issue), the problem still persisted.
The text was updated successfully, but these errors were encountered: