Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respecting appdir #22

Open
Saklad5 opened this issue Oct 26, 2016 · 9 comments
Open

Respecting appdir #22

Saklad5 opened this issue Oct 26, 2016 · 9 comments

Comments

@Saklad5
Copy link

Saklad5 commented Oct 26, 2016

Looking over your code, you install all updated Casks to /Applications, even if they were installed using the --appdir=path parameter and resided somewhere else. Could you update the command to rectify this? If that isn’t possible for some reason, I’d settle for the ability to specify or exclude Casks with the command, perhaps via config file.

@Saklad5
Copy link
Author

Saklad5 commented Oct 30, 2016

Failing that, could you add a “dry run” option that doesn’t do anything after checking each Cask for updates? That would let the user make sure that nothing will be messed up.

@buo
Copy link
Owner

buo commented Oct 30, 2016

@Saklad5 Thanks for your suggestion. I'm gonna add the --dry-run option soon.

buo added a commit that referenced this issue Nov 1, 2016
@jcrben
Copy link

jcrben commented Nov 7, 2016

I think dry-run should be the default behavior. Kicking off something that could take hours to complete is something that should be done carefully.

In addition, people might feel reluctant to interrupt the install as they don't want to leave the system in a weird state (whether that is possible or not)...

@Saklad5
Copy link
Author

Saklad5 commented Nov 26, 2016

I’ve recently “discovered” the brew bundle project, which introduces a unified record (a “Brewfile) of installation from Homebrew, Homebrew-Cask, and even the Mac App Store among other things. Most importantly, it uses easily parsable syntax and can store install arguments.

Would it be possible to, given a path to a Brewfile with the desired arguments added for each Cask, do what I’m asking for here? This seems like it should be quite simple to do, and I might even try my hand if I get the time.

Speaking of which, I appreciate that you are taking the time to consider these changes. So long as you respond to these comments in a timely fashion (within a month, really), I don’t care how long it ends up taking for you to implement these ideas. In the meantime, I can just run brew cu with my hand over Control-C to stop it if it tries to update anything outside of /Applications.

@buo
Copy link
Owner

buo commented Mar 21, 2017

For your information, dry-run became the default behavior in #38.

@Saklad5
Copy link
Author

Saklad5 commented Mar 21, 2017

I noticed, thank you. I feel the command is much approved now that I don't have to rest my hands on Control-C.

By the way, have you noticed that brew cask outdated has been implemented?

@buo
Copy link
Owner

buo commented Mar 23, 2017

@Saklad5 I have seen the updated code, but it doesn't affect this project so far.

@blacktop
Copy link

blacktop commented May 28, 2017

Is there a way to have updates use the same appdir used to install them? I am trying to use cask as a non-admin and when brew cu updates it trys to place it in /Application by default?

@sebma
Copy link

sebma commented Apr 20, 2018

@buo Let me just congratulate you and your team for this great app !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants