-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change behavour of add_tab #587
Comments
Hi @stoivo Thanks for the feedback. We likely wouldn't accept a PR with your proposed suggestion at present due like you say to issues with other customers who may rely on the current behavior. We plan to revisit this interface in the future and try to come up with a more consistent way of handling arrays being added to tabs though. Thanks! |
Ok, not supprized. Stability is defenetly imprtant in a bug tracking software. Thansks for a good product. |
Description
I find the api to add_tab very strange. Why is there such a huge diffence between hashes and arrays?
The current codes looks like
I suggest
I was very confused when I added one tab called
details
and it appeared in the web view asCUSTOM
.It's not realy a issue since I will just wrap slimiar to what I did in my changes. I can open a PR if you are interested in the chang. I think it makes the api more unifor, therefor betterm. On the other hand it chages the behavour so someone might be supprces if it changes.
The text was updated successfully, but these errors were encountered: