-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIELD_SAME_ONEOF is not triggering #2886
Comments
oneof statusInfo {
Booked booked = 100;
- Booked booked_2 = 101;
}
+ Booked booked_2 = 101; See the details on oneof rules: proto3 |
Is there anyway to detect changes on oneof? It's can be quite breaking |
Adding fields is not a breaking change and part of the benefits. Maybe you could explain what you are hoping to achieve or what issues you are having? |
While it's not breaking the message itself, it make the consumer unable to understand it. (Consumer needs to be updated before the producer can use this new field). I'd like to be able to be warned about that one way or another I guess |
Adding a new field to a |
I might have missunderstood the usage of FIELD_SAME_ONEOF as a breaking rule.
My understanding was that it would trigger as long as I add or remove a new field in a oneof .
So I tried the following
Using buf version 1.30.1.
I was expecting it to trigger the rule but it is not.
Am I doing something wrong?
My buf.yaml
The text was updated successfully, but these errors were encountered: