Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: CRD transpiler outputs nullable: false which causes ArgoCD to fail to sync #818

Open
robertcoltheart opened this issue Oct 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@robertcoltheart
Copy link
Contributor

Describe the bug

Not sure why, but ArgoCD has trouble syncing CRDs that have nullable: false in them, which is the default value for a CRD. The fix for this would be to only output when nullable: true.

To reproduce

See below CRD:

apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  name: customs.ns.home.com
spec:
  group: ns.home.com
  names:
    kind: Custom
    listKind: CustomList
    plural: customs
    singular: custom
  scope: Namespaced
  versions:
    - name: v1
      schema:
        openAPIV3Schema:
          properties:
            spec:
              nullable: false
              properties:
                prop1:
                  nullable: false
                  type: string
              required:
                - prop1
              type: object
          type: object
      served: true
      storage: true

Expected behavior

No response

Screenshots

No response

Additional Context

No response

@robertcoltheart robertcoltheart added the bug Something isn't working label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant