Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table View Headers — how to implement? #14

Open
kylebshr opened this issue Apr 2, 2015 · 8 comments
Open

Table View Headers — how to implement? #14

kylebshr opened this issue Apr 2, 2015 · 8 comments

Comments

@kylebshr
Copy link

kylebshr commented Apr 2, 2015

I'm currently having my UITableView fill the view entirely, and setting the content inset to the max height of my flexible bar. This works great without headers, but when I have section headers on my tableview, they are pushed down due to the content inset. Is there a proper way to do this, or do I need to do something hacky? See the photos for details of what I mean.
Before scroll
After scroll — section header is out of place

@bryankeller
Copy link
Owner

Awesome looking app. I'm looking into this now.

@kylebshr
Copy link
Author

kylebshr commented Apr 4, 2015

Great, thank you! To be clear, these are the headers from a .Grouped style UITableView.

@bryankeller
Copy link
Owner

So I know what the issue is, but it's going to take me a few days to find the time to implement a good fix. I'll keep you posted.

@kylebshr
Copy link
Author

kylebshr commented Apr 4, 2015

Good to hear! No rush. I tried to use the scrollViewDidScroll method in the behavior definer to set the insets when it was scrolled, but this was unreliable.

@weibel
Copy link

weibel commented Apr 13, 2015

If any of you have an idea for a good solution to this issue I would be terribly happy to see it :-) I could use it right now. Manipulating the insets in scrollViewDidScroll does not look good.

@bryankeller
Copy link
Owner

It's still on my agenda, but I'm really busy this month. If anyone wants to implement a fix, try to do so in BLKFlexibleHeightBarBehaviorDefiner - this is the base class that all others inherit from, so it would be nice if it can be fixed in one place. Pull requests are welcome =)

That being said, I'll look into this again as soon as I get the chance.

@kylebshr
Copy link
Author

I don’t know too much Objective-C, but I have an idea. I’ll pull and give it a shot.

On Apr 13, 2015, at 2:40 PM, Bryan Keller [email protected] wrote:

It's still on my agenda, but I'm really busy this month. If anyone wants to implement a fix, try to do so in BLKFlexibleHeightBarBehaviorDefiner - this is the base class that all others inherit from, so it would be nice if it can be fixed in one place. Pull requests are welcome =)

That being said, I'll look into this again as soon as I get the chance.


Reply to this email directly or view it on GitHub #14 (comment).

@palcalde
Copy link

Have a look at this and this if solves the issue #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants