Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] As I user I want to download all "Online Presets" at once #139

Open
relascope opened this issue Jan 1, 2024 · 1 comment

Comments

@relascope
Copy link

Using and trying out many different banks is much click-wait-work in the beginning and also when you reinstall OS.

Having this feature can save a lot of boring work.

It would be just an iteration over the "Online Preset"-items, the download and the button.

I didn't have time to dig into the look-and-feel-usage of GTK in guitarix to find a place for the button, but for anybody, who wants it quick and dirty, I just modified PresetWindow::create_preset_menu() in gx_preset_window.cpp to add the line this->downloadPreset(presetMenu, f);
It downloads every "Online Preset" found (and then shows the menu).

    for(std::vector<std::tuple<std::string,std::string,std::string> >::iterator it = olp.begin(); it != olp.end(); it++) {
        item = Gtk::manage(new Gtk::MenuItem(get<0>(*it), true));
        item->set_tooltip_text(get<2>(*it));
        std::string f = get<1>(*it);
        item->signal_activate().connect(
            sigc::bind(sigc::mem_fun(*this, &PresetWindow::downloadPreset),
		       presetMenu, f));

    	this->downloadPreset(presetMenu, f); ////////////////////////// QUICK AND DIRTY HACK

        presetMenu->append(*item);
    }
@brummer10
Copy link
Owner

Maybe it could become a additional menu entry -> Download All

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants