-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: alternative build systems #1920
Labels
Comments
Issue #1977 tracks improving and extending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
People who use alternative build systems like Bazel often do not use the build.rs build script. In 0.17.x we've simplified and refactoed build.rs to make it easier to "port" its logic to 3rd-party build systems. We should document a checklist of steps that a ring user who is not using build.rs, when updating to a new version of ring, as they'll often have to adjust their build logic according to nay changes we've made in build.rs.
For example, in the 0.17.0 release, we added a dependency on the
CARGO_MANIFEST_LINKS
environment variable to build.rs. This broke peoples' Bazel builds because Bazel's rules_rust didn't defineCARGO_MANIFEST_LINKS
. If we had the appropriate checklist for upgrading to a new version of ring with an alternative build system, users would have discovered this.Similarly, in the next upcoming release, we're adding a dependency on
CARGO_CFG_TARGET_VENDOR
and also adding newcfg
logic that needs to be replicated in an alternative build system (ring_x25519_neon
; see #1919). #1832 plans to expand this pattern to all targets.We should note:
The text was updated successfully, but these errors were encountered: