Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating classes with subclasses #43

Open
tommy-waltmann opened this issue Sep 3, 2019 · 2 comments
Open

Deprecating classes with subclasses #43

tommy-waltmann opened this issue Sep 3, 2019 · 2 comments

Comments

@tommy-waltmann
Copy link

tommy-waltmann commented Sep 3, 2019

Deprecation decorator doesn't work on classes if the class being deprecated has a subclass that inherits from it, even if all the subclasses are marked deprecated as well.

@briancurtin
Copy link
Owner

Hey, thanks for the report! That's not something I've come across in the past and don't have a fix off the top of my head. If you happen to beat me to it I'd be happy to review a PR.

@bdice
Copy link
Contributor

bdice commented Sep 3, 2019

I worked a bit with @tommy-waltmann on this problem. From my understanding, decorators and classes don't play nicely together when it comes to inheritance. This StackOverflow post seems related: https://stackoverflow.com/questions/2542747/class-decorators-inheritance-super-and-maximum-recursion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants