Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default fileid #323

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Johann150
Copy link
Collaborator

Resolves #229.

  • add with_file methods to Label and Diagnostic as suggested in the original comment in the issue
  • add new constructors to Label: new_anon, primary_anon and secondary_anon
    These work like their similarly named cousins, but without requiring a file id.

There is probably a better name for the new Label constructors, I could only come up with adding _anon to the end of the existing ones, although these longer names don't quite fit the theme of making things easier IMHO. Maybe @aweary has a better idea?

@Johann150 Johann150 added the enhancement New feature or request label Mar 1, 2021
@Johann150 Johann150 self-assigned this Mar 1, 2021
@Johann150 Johann150 force-pushed the default-fileid branch 2 times, most recently from 7d88b8b to e31a93d Compare March 1, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[codespan-reporting] Don't require FileId when instantiating Label
1 participant